Enable SOXL market signal runtime#117
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53dcb4ae7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| firstrade==0.0.39 | ||
| quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@46ca4ea3de8f98a58e2dd86158e7f2070d085cd1 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@4e638c5fc880253bf22e2e056630fbce6588256a | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@3029fdb868f748b93ffa8b34b8a604df60499c77 |
There was a problem hiding this comment.
Update the project dependency pin too
This updates only requirements.txt, but pyproject.toml still pins us-equity-strategies to 4e638c5.... Because the new market_signal_runtime import relies on the SOXL signal consumer added in the newer strategy-layer commit, installs that use the project metadata (for example the README's python -m pip install -e . path or package builds) will resolve the old dependency and fail to import the application. Please keep the pyproject.toml dependency in sync with this new pin.
Useful? React with 👍 / 👎.
53dcb4a to
61c0976
Compare
61c0976 to
13bf0ff
Compare
…time # Conflicts: # requirements.txt
Summary
Tests